Akshat-Jain commented on code in PR #16358:
URL: https://github.com/apache/druid/pull/16358#discussion_r1592658550
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/MSQTaskQueryMaker.java:
##########
@@ -283,6 +283,10 @@ public QueryResponse<Object[]> runQuery(final DruidQuery
druidQuery)
MSQTaskQueryMakerUtils.validateRealtimeReindex(querySpec);
+ final Map<String, Object> context = new HashMap<>();
+ context.put(PlannerContext.CTX_LOOKUP_LOADING_MODE,
plannerContext.getLookupLoadingSpec().getMode());
+ context.put(PlannerContext.CTX_LOOKUPS_TO_LOAD,
plannerContext.getLookupLoadingSpec().getLookupsToLoad());
Review Comment:
To give an example, if the above keys are added to context only if
mode=ONLY_REQUIRED, `MSQWorkerTask` will end up loading all lookups for queries
without lookups like `select * from datasource`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
