Akshat-Jain commented on code in PR #16358:
URL: https://github.com/apache/druid/pull/16358#discussion_r1592655063
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/MSQTaskQueryMaker.java:
##########
@@ -283,6 +283,10 @@ public QueryResponse<Object[]> runQuery(final DruidQuery
druidQuery)
MSQTaskQueryMakerUtils.validateRealtimeReindex(querySpec);
+ final Map<String, Object> context = new HashMap<>();
+ context.put(PlannerContext.CTX_LOOKUP_LOADING_MODE,
plannerContext.getLookupLoadingSpec().getMode());
+ context.put(PlannerContext.CTX_LOOKUPS_TO_LOAD,
plannerContext.getLookupLoadingSpec().getLookupsToLoad());
Review Comment:
The logic in `MSQWorkerTask#getLookupLoadingSpec` loads all lookups if these
keys aren't present in the context (for backward compatibility reasons). Hence,
we need to set these explicitly even for not loading any lookups.
Attaching snippet of the code in `MSQWorkerTask#getLookupLoadingSpec`:
```java
final Object lookupModeValue =
getContext().get(PlannerContext.CTX_LOOKUP_LOADING_MODE);
if (lookupModeValue == null) {
return LookupLoadingSpec.ALL;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
