kfaraz commented on code in PR #16358:
URL: https://github.com/apache/druid/pull/16358#discussion_r1593339497
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/MSQTaskQueryMaker.java:
##########
@@ -283,6 +283,10 @@ public QueryResponse<Object[]> runQuery(final DruidQuery
druidQuery)
MSQTaskQueryMakerUtils.validateRealtimeReindex(querySpec);
+ final Map<String, Object> context = new HashMap<>();
+ context.put(PlannerContext.CTX_LOOKUP_LOADING_MODE,
plannerContext.getLookupLoadingSpec().getMode());
+ context.put(PlannerContext.CTX_LOOKUPS_TO_LOAD,
plannerContext.getLookupLoadingSpec().getLookupsToLoad());
Review Comment:
+1 to what @cryptoe said.
@Akshat-Jain , @cryptoe meant that we shouldn't add the CTX_LOOKUPS_TO_LOAD
key if the value is going to be null anyway. The key CTX_LOOKUP_LOADING_MODE
should always be added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
