kfaraz commented on code in PR #16481:
URL: https://github.com/apache/druid/pull/16481#discussion_r1616615880
##########
extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/output/RetryableS3OutputStream.java:
##########
@@ -199,15 +229,44 @@ private void pushCurrentChunk() throws IOException
{
currentChunk.close();
final Chunk chunk = currentChunk;
- try {
- if (chunk.length() > 0) {
- resultsSize += chunk.length();
+ if (chunk.length() > 0) {
+ s3UploadConfig.incrementCurrentNumChunks();
Review Comment:
+1, I think this information can be tracked in a singleton called
`S3UploadManager` or something. It is also a little weird to inject the
`ExecutorService` everywhere. That executor service can live inside
`S3UploadManager` so that we have a single place to manage the lifecycle of the
executor. Also, individual `RetryableS3OutputStream` would submit jobs to the
`S3UploadManager`.
It would be this manager that is injected everywhere instead of the raw
`ExecutorService`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
