Akshat-Jain commented on code in PR #16481:
URL: https://github.com/apache/druid/pull/16481#discussion_r1616621024
##########
extensions-core/s3-extensions/src/main/java/org/apache/druid/storage/s3/S3StorageDruidModule.java:
##########
@@ -182,4 +187,20 @@ public Supplier<ServerSideEncryptingAmazonS3>
getAmazonS3ClientSupplier(
{
return Suppliers.memoize(serverSideEncryptingAmazonS3Builder::build);
}
+
+ @Provides
+ @LazySingleton
+ @Named("S3UploadThreadPool")
+ public ExecutorService getUploadPoolExecutorService(ScheduledExecutorFactory
scheduledExecutorFactory, RuntimeInfo runtimeInfo)
+ {
+ int poolSize = Math.max(4, 3 * runtimeInfo.getAvailableProcessors());
Review Comment:
@LakshSingla I made this change as per:
https://github.com/apache/druid/pull/16481#discussion_r1609309586
cc: @cryptoe Can you chime in? Appreciate your thoughts here, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
