Akshat-Jain commented on code in PR #16481:
URL: https://github.com/apache/druid/pull/16481#discussion_r1616716176
##########
extensions-core/s3-extensions/src/test/java/org/apache/druid/storage/s3/S3StorageConnectorProviderTest.java:
##########
@@ -146,6 +148,10 @@ public void configure(Binder binder)
.addValue(
ServerSideEncryptingAmazonS3.class,
new ServerSideEncryptingAmazonS3(null, new
NoopServerSideEncryption())
+ )
+ .addValue(
+ ExecutorService.class,
+ Execs.multiThreaded(10, "UploadThreadPool-%d")
Review Comment:
Fair point, changed it to `Execs.singleThreaded("UploadThreadPool-%d")`
##########
extensions-core/s3-extensions/src/test/java/org/apache/druid/storage/s3/S3StorageConnectorProviderTest.java:
##########
@@ -146,6 +148,10 @@ public void configure(Binder binder)
.addValue(
ServerSideEncryptingAmazonS3.class,
new ServerSideEncryptingAmazonS3(null, new
NoopServerSideEncryption())
+ )
+ .addValue(
+ ExecutorService.class,
+ Execs.multiThreaded(10, "UploadThreadPool-%d")
Review Comment:
Fair point, will change it to `Execs.singleThreaded("UploadThreadPool-%d")`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
