amaechler commented on code in PR #16558:
URL: https://github.com/apache/druid/pull/16558#discussion_r1628375979
##########
extensions-core/azure-extensions/src/main/java/org/apache/druid/storage/azure/output/AzureStorageConnector.java:
##########
@@ -196,7 +196,7 @@ public Iterator<String> listDir(String dirName) throws
IOException
final String prefixBasePath = objectPath(dirName);
List<String> paths;
try {
- paths = azureStorage.listDir(config.getContainer(), prefixBasePath,
config.getMaxRetry());
+ paths = azureStorage.listBlobs(config.getContainer(), prefixBasePath,
null, config.getMaxRetry());
Review Comment:
Renamed `listDir` to use more specific Azure terminology inside the
`Storage` wrapper.
##########
extensions-core/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureUtils.java:
##########
@@ -37,8 +37,6 @@
*/
public class AzureUtils
{
-
- public static final String DEFAULT_AZURE_ENDPOINT_SUFFIX =
"core.windows.net";
Review Comment:
Unused.
##########
extensions-core/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureDataSegmentKiller.java:
##########
@@ -43,7 +43,6 @@
public class AzureDataSegmentKiller implements DataSegmentKiller
{
private static final Logger log = new Logger(AzureDataSegmentKiller.class);
- private static final Integer MAX_MULTI_OBJECT_DELETE_SIZE = 256; //
https://learn.microsoft.com/en-us/rest/api/storageservices/blob-batch?tabs=microsoft-entra-id
Review Comment:
This was not used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
