amaechler commented on code in PR #16558: URL: https://github.com/apache/druid/pull/16558#discussion_r1628458947
########## extensions-core/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureStorage.java: ########## @@ -56,255 +54,391 @@ */ public class AzureStorage Review Comment: That's a valid question. - `getBlobContainerClient` does nothing yet. It simply creates a client that will be used for an API call later. - `createBlobContainerIfNotExists` first [calls](https://github.com/Azure/azure-sdk-for-java/blob/5648561dc792a993ec0fb4b041d76dc64971b9bb/sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobServiceClient.java#L206-L211) `getBlobContainerClient`, and then right away executes an API call (`createIfNotExistsWithResponse`) for that client. In the current implementation, if you _configure_ a container that does not exist, the calls that I found call `azureStorage.getBlockBlobExists` first, which then simply returns `false` (called for streaming task files, or from the storage layer). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
