georgew5656 commented on code in PR #16558: URL: https://github.com/apache/druid/pull/16558#discussion_r1628439982
########## extensions-core/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureStorage.java: ########## @@ -56,255 +54,391 @@ */ public class AzureStorage Review Comment: thinking about it a bit more, the first write operation is always triggered by a task, either a msq task pushing intermediate segments, or the middleManager/overlord pushing task logs. this seems ok to me, the only class of things i can think of failing are like, e.g. the task logs cleaner. but if that throws a exception it would be fine since no tasks would have been run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
