AmatyaAvadhanula commented on code in PR #16667:
URL: https://github.com/apache/druid/pull/16667#discussion_r1671721200
##########
server/src/main/java/org/apache/druid/metadata/PendingSegmentRecord.java:
##########
@@ -40,7 +40,7 @@
* <li> id -> id (Unique identifier for pending segment) <li/>
* <li> sequence_name -> sequenceName (sequence name used for segment
allocation) <li/>
* <li> sequence_prev_id -> sequencePrevId (previous segment id used for
segment allocation) <li/>
- * <li> upgraded_from_segment_id -> upgradedFromSegmentId (Id of the root
segment from which this was upgraded) <li/>
+ * <li> upgraded_from_segment_id -> upgradedFromSegmentId (Id of the first
segment from which this was upgraded) <li/>
Review Comment:
Done
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/KillUnusedSegmentsTask.java:
##########
@@ -203,11 +208,9 @@ public TaskStatus runTask(TaskToolbox toolbox) throws
Exception
);
// Fetch the load specs of all segments overlapping with the unused
segment intervals
final Set<Map<String, Object>> usedSegmentLoadSpecs =
- new
HashSet<>(toolbox.getTaskActionClient().submit(retrieveUsedSegmentsAction)
- .stream()
- .map(DataSegment::getLoadSpec)
- .collect(Collectors.toSet())
- );
+ toolbox.getTaskActionClient().submit(retrieveUsedSegmentsAction)
+ .stream()
+ .map(DataSegment::getLoadSpec).collect(Collectors.toSet());
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
