AmatyaAvadhanula commented on code in PR #16667:
URL: https://github.com/apache/druid/pull/16667#discussion_r1671726861
##########
indexing-service/src/test/java/org/apache/druid/indexing/test/TestIndexerMetadataStorageCoordinator.java:
##########
@@ -314,6 +315,26 @@ public List<PendingSegmentRecord>
getPendingSegments(String datasource, Interval
throw new UnsupportedOperationException();
}
+ @Override
+ public List<SegmentUpgradeInfo> retrieveUpgradedFromSegmentIds(
+ final String dataSource,
+ final List<String> segmentIds
+ )
+ {
+ List<SegmentUpgradeInfo> segmentUpgradeInfos = new ArrayList<>();
+ segmentIds.forEach(id -> segmentUpgradeInfos.add(new
SegmentUpgradeInfo(id, null)));
+ return segmentUpgradeInfos;
+ }
+
+ @Override
+ public List<SegmentUpgradeInfo> retrieveUpgradedToSegmentIds(
+ final String dataSource,
+ final List<String> upgradedFromSegmentIds
+ )
+ {
+ return Collections.emptyList();
Review Comment:
There are tests for this functionality in KillUnusedSegmentsTaskTest
These methods are for TaskLifecycleTest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
