AmatyaAvadhanula commented on code in PR #16667:
URL: https://github.com/apache/druid/pull/16667#discussion_r1671722544
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentTransactionalReplaceAction.java:
##########
@@ -52,7 +52,7 @@
* commit input segments contained within interval
* upgrade ids in the upgradeSegments table corresponding to this task
to the replace lock's version and commit them
* fetch payload, task_allocator_id for pending segments
- * upgrade each such pending segment to the replace lock's version with
the corresponding root segment
+ * upgrade each such pending segment to the replace lock's version with
the corresponding upgraded from segment
Review Comment:
Done
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/KillUnusedSegmentsTask.java:
##########
@@ -203,11 +208,9 @@ public TaskStatus runTask(TaskToolbox toolbox) throws
Exception
);
// Fetch the load specs of all segments overlapping with the unused
segment intervals
final Set<Map<String, Object>> usedSegmentLoadSpecs =
- new
HashSet<>(toolbox.getTaskActionClient().submit(retrieveUsedSegmentsAction)
- .stream()
- .map(DataSegment::getLoadSpec)
- .collect(Collectors.toSet())
- );
+ toolbox.getTaskActionClient().submit(retrieveUsedSegmentsAction)
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
