AmatyaAvadhanula commented on code in PR #16667:
URL: https://github.com/apache/druid/pull/16667#discussion_r1671723587
##########
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java:
##########
@@ -1408,13 +1416,15 @@ private SegmentPublishResult
commitAppendSegmentsAndMetadataInTransaction(
final Set<DataSegment> allSegmentsToInsert = new HashSet<>(appendSegments);
final Map<SegmentId, SegmentId> newVersionSegmentToParent = new
HashMap<>();
final Map<String, DataSegment> segmentIdMap = new HashMap<>();
+ final Map<SegmentId, String> upgradedFromSegmentIdMap = new HashMap<>();
Review Comment:
Done
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/RetrieveUpgradedToSegmentsIdsAction.java:
##########
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.druid.indexing.common.actions;
+
+import com.fasterxml.jackson.annotation.JsonCreator;
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.core.type.TypeReference;
+import com.google.common.collect.ImmutableList;
+import org.apache.druid.indexing.common.task.Task;
+import org.apache.druid.metadata.SegmentUpgradeInfo;
+
+import java.util.List;
+import java.util.Objects;
+import java.util.Set;
+
+/**
+ * Task action to retrieve the segment upgrade infos of a given set of used or
unused upgraded segment ids.
+ */
+public class RetrieveUpgradedToSegmentsIdsAction implements
TaskAction<List<SegmentUpgradeInfo>>
+{
+ private final String dataSource;
+ private final Set<String> upgradedSegmentIds;
+
+ @JsonCreator
+ public RetrieveUpgradedToSegmentsIdsAction(
+ @JsonProperty("dataSource") String dataSource,
+ @JsonProperty("upgradedSegmentIds") Set<String> upgradedSegmentIds
+ )
+ {
+ this.dataSource = dataSource;
+ this.upgradedSegmentIds = upgradedSegmentIds;
+ }
+
+ @JsonProperty
+ public String getDataSource()
+ {
+ return dataSource;
+ }
+
+ @JsonProperty
+ public Set<String> getUpgradedSegmentIds()
+ {
+ return upgradedSegmentIds;
+ }
+
+ @Override
+ public TypeReference<List<SegmentUpgradeInfo>> getReturnTypeReference()
+ {
+ return new TypeReference<List<SegmentUpgradeInfo>>()
+ {
+ };
+ }
+
+ @Override
+ public List<SegmentUpgradeInfo> perform(Task task, TaskActionToolbox toolbox)
Review Comment:
Followed option 3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
