AmatyaAvadhanula commented on code in PR #16667:
URL: https://github.com/apache/druid/pull/16667#discussion_r1671725819
##########
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java:
##########
@@ -2923,6 +2944,77 @@ public int deleteUpgradeSegmentsForTask(final String
taskId)
);
}
+ @Override
+ public List<SegmentUpgradeInfo> retrieveUpgradedFromSegmentIds(
+ final String dataSource,
+ final List<String> segmentIds
+ )
+ {
+ if (segmentIds.isEmpty()) {
+ return Collections.emptyList();
+ }
+
+ final String sql = StringUtils.format(
+ "SELECT id, upgraded_from_segment_id FROM %s WHERE dataSource =
:dataSource %s",
+ dbTables.getSegmentsTable(),
+ SqlSegmentsMetadataQuery.getParameterizedInConditionForColumn("id",
segmentIds)
+ );
+ return connector.retryWithHandle(
+ handle -> {
+ Query<Map<String, Object>> query = handle.createQuery(sql)
+ .bind("dataSource",
dataSource);
+
SqlSegmentsMetadataQuery.bindColumnValuesToQueryWithInCondition("id",
segmentIds, query);
+ return query.map(
+ (index, r, ctx) -> {
+ final String id = r.getString(1);
+ final String upgradedFromSegmentId = r.getString(2);
+ return new SegmentUpgradeInfo(id, upgradedFromSegmentId);
+ }
+ )
+ .list();
+ }
+ );
+ }
+
+ @Override
+ public List<SegmentUpgradeInfo> retrieveUpgradedToSegmentIds(
+ final String dataSource,
+ final List<String> upgradedFromSegmentIds
+ )
+ {
+ if (upgradedFromSegmentIds.isEmpty()) {
+ return Collections.emptyList();
+ }
+
+ final String sql = StringUtils.format(
+ "SELECT id, upgraded_from_segment_id FROM %s WHERE dataSource =
:dataSource %s",
+ dbTables.getSegmentsTable(),
+ SqlSegmentsMetadataQuery.getParameterizedInConditionForColumn(
+ "upgraded_from_segment_id",
+ upgradedFromSegmentIds
+ )
+ );
+ return connector.retryWithHandle(
+ handle -> {
+ Query<Map<String, Object>> query = handle.createQuery(sql)
+ .bind("dataSource",
dataSource);
+ SqlSegmentsMetadataQuery.bindColumnValuesToQueryWithInCondition(
+ "upgraded_from_segment_id",
+ upgradedFromSegmentIds,
+ query
+ );
+ return query.map(
+ (index, r, ctx) -> {
+ final String id = r.getString(1);
+ final String upgradedFromSegmentId = r.getString(2);
+ return new SegmentUpgradeInfo(id, upgradedFromSegmentId);
+ }
+ )
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
