Akshat-Jain commented on code in PR #16854:
URL: https://github.com/apache/druid/pull/16854#discussion_r1713158150
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/WindowOperatorQueryKit.java:
##########
@@ -122,13 +137,13 @@ public QueryDefinition makeQueryDefinition(
queryDefBuilder.add(
StageDefinition.builder(firstStageNumber)
.inputs(new StageInputSpec(firstStageNumber - 1))
- .signature(rowSignature)
+ .signature(finalWindowStageRowSignature)
.maxWorkerCount(maxWorkerCount)
- .shuffleSpec(null)
+ .shuffleSpec(finalWindowStageShuffleSpec)
Review Comment:
This is being done only for the last window stage. If we have an empty
over() clause present in the window function, we create a single window stage
instead of separate stages.
With that said, I've pushed a change to add the virtual columns also only
for the last window stage. Hope that works!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
