adarshsanjeev commented on code in PR #16854:
URL: https://github.com/apache/druid/pull/16854#discussion_r1713279758
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/WindowOperatorQueryKit.java:
##########
@@ -122,13 +137,13 @@ public QueryDefinition makeQueryDefinition(
queryDefBuilder.add(
StageDefinition.builder(firstStageNumber)
.inputs(new StageInputSpec(firstStageNumber - 1))
- .signature(rowSignature)
+ .signature(finalWindowStageRowSignature)
.maxWorkerCount(maxWorkerCount)
- .shuffleSpec(null)
+ .shuffleSpec(finalWindowStageShuffleSpec)
Review Comment:
From what I can understand, you are adding logic which uses the segment
granularity to decide the shuffling. However, it would be possible to have more
than one window stage in a query, and the query does not need to be followed by
a segment generation stage. You can add a limit to a window query to see this
behavior. I am wondering if this case is covered as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
