Akshat-Jain commented on code in PR #16854:
URL: https://github.com/apache/druid/pull/16854#discussion_r1713296563
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/WindowOperatorQueryKit.java:
##########
@@ -122,13 +137,13 @@ public QueryDefinition makeQueryDefinition(
queryDefBuilder.add(
StageDefinition.builder(firstStageNumber)
.inputs(new StageInputSpec(firstStageNumber - 1))
- .signature(rowSignature)
+ .signature(finalWindowStageRowSignature)
.maxWorkerCount(maxWorkerCount)
- .shuffleSpec(null)
+ .shuffleSpec(finalWindowStageShuffleSpec)
Review Comment:
For the above query, these are the stages we get:
```
stageDefinition.getProcessorFactory() =
org.apache.druid.msq.querykit.groupby.GroupByPreShuffleFrameProcessorFactory@737a033
stageDefinition.getSignature() = {d0:STRING, d1:STRING, d2:STRING}
stageDefinition.getStageNumber() = 0
stageDefinition.getShuffleSpec() =
MaxCountShuffleSpec{clusterBy=ClusterBy{columns=[d0 ASCENDING, d1 ASCENDING, d2
ASCENDING], bucketByCount=0}, partitions=1, aggregate=true}
stageDefinition.getProcessorFactory() =
org.apache.druid.msq.querykit.groupby.GroupByPostShuffleFrameProcessorFactory@3b66dec
stageDefinition.getSignature() = {d0:STRING, d1:STRING, d2:STRING}
stageDefinition.getStageNumber() = 1
stageDefinition.getShuffleSpec() =
HashShuffleSpec{clusterBy=ClusterBy{columns=[d0 ASCENDING], bucketByCount=0},
numPartitions=1}
stageDefinition.getProcessorFactory() =
org.apache.druid.msq.querykit.WindowOperatorQueryFrameProcessorFactory@d45add62
stageDefinition.getSignature() = {d1:STRING, d0:STRING, d2:STRING, w0:LONG}
stageDefinition.getStageNumber() = 2
stageDefinition.getShuffleSpec() =
HashShuffleSpec{clusterBy=ClusterBy{columns=[d1 ASCENDING], bucketByCount=0},
numPartitions=1}
stageDefinition.getProcessorFactory() =
org.apache.druid.msq.querykit.WindowOperatorQueryFrameProcessorFactory@643913d9
stageDefinition.getSignature() = {d0:STRING, d1:STRING, d2:STRING, w0:LONG,
w1:LONG}
stageDefinition.getStageNumber() = 3
stageDefinition.getShuffleSpec() = MixShuffleSpec{}
stageDefinition.getProcessorFactory() =
org.apache.druid.msq.querykit.scan.ScanQueryFrameProcessorFactory@687279fb
stageDefinition.getSignature() = {__boost:LONG, d0:STRING, d1:STRING,
d2:STRING, w0:LONG, w1:LONG}
stageDefinition.getStageNumber() = 4
stageDefinition.getShuffleSpec() = MixShuffleSpec{}
stageDefinition.getProcessorFactory() =
org.apache.druid.msq.querykit.common.OffsetLimitFrameProcessorFactory@3c8
stageDefinition.getSignature() = {__boost:LONG, d0:STRING, d1:STRING,
d2:STRING, w0:LONG, w1:LONG}
stageDefinition.getStageNumber() = 5
stageDefinition.getShuffleSpec() =
MaxCountShuffleSpec{clusterBy=ClusterBy{columns=[__boost ASCENDING],
bucketByCount=0}, partitions=1, aggregate=false}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
