LakshSingla commented on code in PR #16854:
URL: https://github.com/apache/druid/pull/16854#discussion_r1714893678
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/WindowOperatorQueryFrameProcessor.java:
##########
@@ -119,6 +123,15 @@ public WindowOperatorQueryFrameProcessor(
for (int i = 0; i < frameReader.signature().size(); i++) {
typeStrategies[i] =
frameReader.signature().getColumnType(i).get().getNullableStrategy();
}
+
+ // Get virtual columns to be added to the frame writer.
+ final List<VirtualColumn> frameWriterVirtualColumns = new ArrayList<>();
+ final VirtualColumn segmentGranularityVirtualColumn =
+ QueryKitUtils.makeSegmentGranularityVirtualColumn(jsonMapper, query);
+ if (segmentGranularityVirtualColumn != null) {
+ frameWriterVirtualColumns.add(segmentGranularityVirtualColumn);
+ }
+ this.frameWriterVirtualColumns =
VirtualColumns.create(frameWriterVirtualColumns);
Review Comment:
nit, cleaner. Don't need to check for null, or create an array list.
```suggestion
this.frameWriterVirtualColumns = VirtualColumns.create(
QueryKitUtils.makeSegmentGranularityVirtualColumn(jsonMapper, query)
);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
