LakshSingla commented on code in PR #16864:
URL: https://github.com/apache/druid/pull/16864#discussion_r1719371483
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQCompactionRunner.java:
##########
@@ -497,6 +502,7 @@ private Map<String, Object>
createMSQTaskContext(CompactionTask compactionTask,
context.put(QueryContexts.FINALIZE_KEY, false);
// Only scalar or array-type dimensions are allowed as grouping keys.
context.putIfAbsent(GroupByQueryConfig.CTX_KEY_ENABLE_MULTI_VALUE_UNNESTING,
false);
+ context.putIfAbsent(MultiStageQueryContext.CTX_ARRAY_INGEST_MODE, "array");
Review Comment:
Finalize still makes some sense, however, with MVD mode with compaction is a
sure shot way to shoot oneself in the foot. It still exists for ingestion for
some historical reasons - We only ingested MVDs + it is difficult to change the
queries once the data is ingested as an MVD. For compaction, it makes little
sense to modify a string from array to MVD.
Anyways, we don't need to block this patch for this discussion and can
probably take it in a follow-up if need be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
