clintropolis commented on code in PR #16864:
URL: https://github.com/apache/druid/pull/16864#discussion_r1714610336
##########
integration-tests/src/test/java/org/apache/druid/tests/coordinator/duty/ITAutoCompactionTest.java:
##########
@@ -515,6 +518,45 @@ public void
testAutoCompactionOnlyRowsWithMetricShouldPreserveExistingMetrics()
}
}
+ @Test(dataProvider = "engine")
+ public void
testAutoCompactionPreservesCreateBitmapIndexInDimensionSchema(CompactionEngine
engine) throws Exception
Review Comment:
would be nice to add a test that uses `AutoTypeColumnSchema` for like a long
column to ensure that it is recreated with `AutoTypeColumnSchema` instead of
`LongDimensionSchema` (or similar with double) ('auto' longs have indexes while
classic longs do not)
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -2122,13 +2123,33 @@ private static StringTuple makeStringTuple(
return new StringTuple(array);
}
+ private static DimensionSchema getDimensionSchema(
+ final String outputColumnName,
+ @Nullable final ColumnType queryType,
+ QueryContext context,
+ @Nullable Map<String, DimensionSchema> dimensionToSchemaMap
+ )
+ {
+ if (dimensionToSchemaMap != null &&
dimensionToSchemaMap.containsKey(outputColumnName)) {
+ return dimensionToSchemaMap.get(outputColumnName);
+ }
+ // For aggregators moved to dimensions, we won't have an entry in the map.
For those cases, use the default config.
Review Comment:
this also happens for like regular ingestions which are not compaction,
right? comment makes it seem only like aggs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
