gargvishesh commented on code in PR #16864:
URL: https://github.com/apache/druid/pull/16864#discussion_r1714743038
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -2122,13 +2123,33 @@ private static StringTuple makeStringTuple(
return new StringTuple(array);
}
+ private static DimensionSchema getDimensionSchema(
+ final String outputColumnName,
+ @Nullable final ColumnType queryType,
+ QueryContext context,
+ @Nullable Map<String, DimensionSchema> dimensionToSchemaMap
+ )
+ {
+ if (dimensionToSchemaMap != null &&
dimensionToSchemaMap.containsKey(outputColumnName)) {
+ return dimensionToSchemaMap.get(outputColumnName);
+ }
+ // For aggregators moved to dimensions, we won't have an entry in the map.
For those cases, use the default config.
Review Comment:
Yes, thanks for pointing out. Updated the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
