gargvishesh commented on code in PR #16864:
URL: https://github.com/apache/druid/pull/16864#discussion_r1719345684
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQCompactionRunner.java:
##########
@@ -497,6 +502,7 @@ private Map<String, Object>
createMSQTaskContext(CompactionTask compactionTask,
context.put(QueryContexts.FINALIZE_KEY, false);
// Only scalar or array-type dimensions are allowed as grouping keys.
context.putIfAbsent(GroupByQueryConfig.CTX_KEY_ENABLE_MULTI_VALUE_UNNESTING,
false);
+ context.putIfAbsent(MultiStageQueryContext.CTX_ARRAY_INGEST_MODE, "array");
Review Comment:
If a user explicitly sets this flag for compaction, it would be out of a
conscious choice. It's the same for all the flags above which may not ideally
make sense for compaction but are set for some reason (e.g. finalize), and
would end up in some valid output.
We do already have a warn log for array_ingest_mode = `mvd` in the
controller, so not adding another one here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
