abhishekagarwal87 commented on code in PR #16672:
URL: https://github.com/apache/druid/pull/16672#discussion_r1728428367
##########
server/src/main/java/org/apache/druid/server/QueryResultPusher.java:
##########
@@ -120,7 +125,9 @@ public Response push()
final Response.ResponseBuilder startResponse = resultsWriter.start();
if (startResponse != null) {
- startResponse.header(QueryResource.QUERY_ID_RESPONSE_HEADER, queryId);
+ startResponse.header(QueryResource.QUERY_ID_RESPONSE_HEADER, queryId)
Review Comment:
can you point me to the RFC that mandates populating this field? From what I
read, its only required when you want the receiver to prep for that trailer
field .e.g checksum. In this case, we could send just the "response complete"
trailer header so that clients will know that they can expect an error message
at the end if the response is truncated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
