vivek807 commented on code in PR #16672:
URL: https://github.com/apache/druid/pull/16672#discussion_r1731360742
##########
server/src/main/java/org/apache/druid/server/QueryResultPusher.java:
##########
@@ -120,7 +125,9 @@ public Response push()
final Response.ResponseBuilder startResponse = resultsWriter.start();
if (startResponse != null) {
- startResponse.header(QueryResource.QUERY_ID_RESPONSE_HEADER, queryId);
+ startResponse.header(QueryResource.QUERY_ID_RESPONSE_HEADER, queryId)
Review Comment:
Right, it is not mandatory. So if it not needed we can remove it. Just
double checking if `caller to know beforehand` is not something we can skip.
Let me know
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
