abhishekagarwal87 commented on code in PR #16672:
URL: https://github.com/apache/druid/pull/16672#discussion_r1729025858


##########
server/src/main/java/org/apache/druid/server/QueryResultPusher.java:
##########
@@ -120,7 +125,9 @@ public Response push()
 
       final Response.ResponseBuilder startResponse = resultsWriter.start();
       if (startResponse != null) {
-        startResponse.header(QueryResource.QUERY_ID_RESPONSE_HEADER, queryId);
+        startResponse.header(QueryResource.QUERY_ID_RESPONSE_HEADER, queryId)

Review Comment:
   It doesn't say that you must specify this header. Only when you want the 
caller to know beforehand that such a trailer will be added. We can remove this 
header entirely. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to