Akshat-Jain commented on code in PR #17443:
URL: https://github.com/apache/druid/pull/17443#discussion_r1832111126
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/DataSourcePlan.java:
##########
@@ -413,15 +418,25 @@ private static DataSourcePlan forLookup(
private static DataSourcePlan forQuery(
final QueryKitSpec queryKitSpec,
final QueryDataSource dataSource,
+ final QueryContext queryContext,
Review Comment:
The changes of this file are essentially to pass the
`WINDOW_FUNCTION_OPERATOR_TRANSFORMATION` flag to the `WindowOperatorQueryKit`
layer (as otherwise the flag set in `MSQTaskQueryMaker` layer isn't passed to
`WindowOperatorQueryKit`).
So, for that, I needed to set the flag in the `query` being passed in
`queryKitSpec.getQueryKit().makeQueryDefinition()` call in this method.
So I've passed the query context to this method to be able to get the flag's
value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
