Akshat-Jain commented on code in PR #17443:
URL: https://github.com/apache/druid/pull/17443#discussion_r1832124039
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/DataSourcePlan.java:
##########
@@ -413,15 +418,25 @@ private static DataSourcePlan forLookup(
private static DataSourcePlan forQuery(
final QueryKitSpec queryKitSpec,
final QueryDataSource dataSource,
+ final QueryContext queryContext,
Review Comment:
I'm not sure why we don't pass query context through the queryKit layers
directly. We can certainly add a `queryContext` param in
`QueryKit#makeQueryDefinition` interface method, and it'll help clean up the
changes of DataSourcePlan layer.
I don't have a strong preference either way on this, happy to make the
change if you'd prefer that.
(Although on second thoughts, a better way to do it might be to take it as a
separate work item, and also check if some existing logic of DataSourcePlan
layer also becomes unnecessary after passing query context directly - not sure
if that might be the case though)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
