cryptoe commented on code in PR #17443:
URL: https://github.com/apache/druid/pull/17443#discussion_r1832129015
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/DataSourcePlan.java:
##########
@@ -413,15 +418,25 @@ private static DataSourcePlan forLookup(
private static DataSourcePlan forQuery(
final QueryKitSpec queryKitSpec,
final QueryDataSource dataSource,
+ final QueryContext queryContext,
Review Comment:
Its confusing.
As a developer, dataSource.getQuery() should have all the data that is
required for me to take a decision. Like the most obvious question is how is
datasource.getQuery().getCOntext() different from queryContext. That nuance is
hard to reason about when a person is writing an implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
