cryptoe commented on code in PR #17443:
URL: https://github.com/apache/druid/pull/17443#discussion_r1836969620
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/WindowOperatorQueryKit.java:
##########
@@ -54,10 +57,12 @@ public class WindowOperatorQueryKit implements
QueryKit<WindowOperatorQuery>
{
private static final Logger log = new Logger(WindowOperatorQueryKit.class);
private final ObjectMapper jsonMapper;
+ private final QueryContext queryContext;
Review Comment:
I would just store the flag is WindowedOperationTranformEnabled no ?
There is no need to store the entire context as a class level object. I
would go one level further and just pass the flag from outside. Ie
`new
WindowOperatorQueryKit(context.jsonMapper(),isGlueingTranformEnabled()))` so
that queryKits never see the "high level context" and all logic is contained in
the controller impl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
