kgyrtkirk commented on code in PR #17572:
URL: https://github.com/apache/druid/pull/17572#discussion_r1892592049
##########
sql/src/test/java/org/apache/druid/sql/calcite/util/SqlTestFramework.java:
##########
@@ -896,13 +933,12 @@ private SqlTestFramework(Builder builder)
// test pulls in a module, then pull in that module, even though we are
// not the Druid node to which the module is scoped.
.ignoreLoadScopes();
- List<Module> overrideModules = new ArrayList<>(builder.overrideModules);
- overrideModules.add(new LookylooModule());
- overrideModules.add(new SqlAggregationModule());
- overrideModules.add(new SegmentWranglerModule());
- overrideModules.add(new ExpressionModule());
+ ArrayList<Module> overrideModules = new
ArrayList<>(builder.overrideModules);
+
+ injectorBuilder.add(componentSupplier.getCoreModule());
overrideModules.add(testSetupModule());
+ overrideModules.add(componentSupplier.getOverrideModule());
Review Comment:
based on offline discussion: the problem here was that `testSetupModule()`
was fully wired in - which could become problematic
I've made the `TestSetupModule` added by the `componentSupplier` in the
`OverrideModule` ; so it will be easier to override even these things more
easily
I've also reorganized some parts of `TestSetupModule` into a separate
module - for which later there will be a different implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
