kgyrtkirk commented on code in PR #17572:
URL: https://github.com/apache/druid/pull/17572#discussion_r1892599849
##########
server/src/main/java/org/apache/druid/guice/DruidBinders.java:
##########
@@ -62,32 +66,68 @@ public static MapBinder<Class<? extends Query>, QueryLogic>
queryLogicBinderType
);
}
- public static QueryLogicBinder queryLogicBinder(Binder binder)
+ public static QueryBinder queryBinder(Binder binder)
{
- return new QueryLogicBinder(binder);
+ return new QueryBinder(binder);
}
- public static class QueryLogicBinder
+ public static class QueryBinder
{
- private MapBinder<Class<? extends Query>, QueryLogic> queryLogicMapBinder;
- private Binder binder;
+ MapBinderHelper<Class<? extends Query>, QueryLogic> queryLogicBinder;
+ MapBinderHelper<Class<? extends Query>, QueryRunnerFactory>
queryRunnerFactoryBinder;
+ MapBinderHelper<Class<? extends Query>, QueryToolChest>
queryToolChestBinder;
+
- public QueryLogicBinder(Binder binder)
+ public QueryBinder(Binder binder)
{
- this.binder = binder;
- queryLogicMapBinder = DruidBinders.queryLogicBinderType(binder);
+ queryLogicBinder = new MapBinderHelper<>(
+ binder, queryLogicBinderType(binder),
ImmutableSet.of(LazySingleton.class)
Review Comment:
none of the changes in this file are really necessary anymore - as the PR
now relies on using `QueryRunnerFactoryModule` to load the all these things.
should I undo the change in this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
