jiawulin001 commented on code in PR #16880:
URL: https://github.com/apache/echarts/pull/16880#discussion_r851836766
##########
src/coord/cartesian/Grid.ts:
##########
@@ -202,10 +200,32 @@ class Grid implements CoordinateSystemMaster {
}
}
});
-
+ //Adjust grid.width to keep xAxis labels in dom
+ const [xAxis, yAxis] = axesList[0].isHorizontal() ? axesList :
axesList.slice().reverse();
Review Comment:
The function `labelUnionRect` actually returns the largest bounding box of
all labels of an axis, not the union bounding box. So I am not sure how to get
the union rect of xAxis with this function. Also it would be hard to get the
real size of displayed bounding box of labels because echarts seems to
automatically clip labels according to axis length. That's why we just need to
make sure the first/last label does not exceed the dom. Please correct me if I
misunderstand you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
