pissang commented on code in PR #16880:
URL: https://github.com/apache/echarts/pull/16880#discussion_r852532654
##########
src/coord/cartesian/Grid.ts:
##########
@@ -202,10 +200,32 @@ class Grid implements CoordinateSystemMaster {
}
}
});
-
+ //Adjust grid.width to keep xAxis labels in dom
+ const [xAxis, yAxis] = axesList[0].isHorizontal() ? axesList :
axesList.slice().reverse();
Review Comment:
> . If we cut the grid according to bounding rect, there would appear a huge
white margin to the right of the grid, and user won't ever know why.
Indeed it is an issue that's common in the layout systems. But how will
"only picking right-most label" fix it? It may still happen that the right-most
label is hidden after grid size changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
