pissang commented on code in PR #16880:
URL: https://github.com/apache/echarts/pull/16880#discussion_r851986540
##########
src/coord/cartesian/Grid.ts:
##########
@@ -202,10 +200,32 @@ class Grid implements CoordinateSystemMaster {
}
}
});
-
+ //Adjust grid.width to keep xAxis labels in dom
+ const [xAxis, yAxis] = axesList[0].isHorizontal() ? axesList :
axesList.slice().reverse();
Review Comment:
But still I think getting a union bounding rect and check if the rect excced
the dom is a more proper way.
We can use the first calculated result to position the labels. Then
recalculate the grid size based on the first calculated union bounding rect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
