pissang commented on code in PR #16880:
URL: https://github.com/apache/echarts/pull/16880#discussion_r852540664
##########
src/coord/cartesian/Grid.ts:
##########
@@ -202,10 +200,32 @@ class Grid implements CoordinateSystemMaster {
}
}
});
-
+ //Adjust grid.width to keep xAxis labels in dom
+ const [xAxis, yAxis] = axesList[0].isHorizontal() ? axesList :
axesList.slice().reverse();
Review Comment:
> So what I want to emphasize is right-most DISPLAYED label. The function
getTicksCoord would only return the labels that would be DISPLAYED. Those which
are automatically hidden will not be included so I can just call
getTicksCoord()[0] to get the left-most DISPLAYED label and the right-most
alike.
I think that's not the difference. The union bounding rect should also be
from the displayed labels .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
