jiawulin001 commented on code in PR #16880:
URL: https://github.com/apache/echarts/pull/16880#discussion_r852545150
##########
src/coord/cartesian/Grid.ts:
##########
@@ -202,10 +200,32 @@ class Grid implements CoordinateSystemMaster {
}
}
});
-
+ //Adjust grid.width to keep xAxis labels in dom
+ const [xAxis, yAxis] = axesList[0].isHorizontal() ? axesList :
axesList.slice().reverse();
Review Comment:
Hmmm, do you mean use `getTicksCoord` to find displayed labels index, find
their bounding box and implement union bounding rects on them? I don't see why
we need to do that. Are you worrying that some too long in-middle label would
exceed the dom too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
