Ovilia commented on code in PR #20705:
URL: https://github.com/apache/echarts/pull/20705#discussion_r1924779709


##########
src/model/Global.ts:
##########
@@ -543,6 +543,14 @@ echarts.use([${seriesImportName}]);`);
         return option;
     }
 
+    setTheme(theme: object) {
+        this._theme = new Model(theme);
+        // Merge theme with current option directly
+        mergeTheme(this.option, this._theme.option);

Review Comment:
   OK. I tested it works without `mergeTheme`. Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to