100pah commented on code in PR #20705:
URL: https://github.com/apache/echarts/pull/20705#discussion_r1925224246
##########
src/core/echarts.ts:
##########
@@ -693,10 +685,30 @@ class ECharts extends Eventful<ECEventDefinition> {
}
/**
- * @deprecated
+ * Update theme with name or theme option and repaint the chart.
+ * @param theme Theme name or theme option.
*/
- private setTheme(): void {
- deprecateLog('ECharts#setTheme() is DEPRECATED in ECharts 3.0');
+ setTheme(theme: string | ThemeOption): void {
+ this._updateTheme(theme);
+ if (this._model) {
+ this._model.setTheme(this._theme);
+ // Force refresh to apply theme changes
+ updateMethods.prepareAndUpdate.call(this, {
+ type: 'themeChanged'
Review Comment:
I prefer to add a null checker in `prepareAndUpdate`
or call
```js
prepare(this);
updateMethods.update.call(this);
```
instead.
Do not use a payload because I think that a payload typically suggests this
in an action but this is a explicit call rather than trigger an action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
