vorburger commented on a change in pull request #642: FINERACT-724 Upgrade Spring Boot, Spring and Spring Security to their latest stable version URL: https://github.com/apache/fineract/pull/642#discussion_r335001379
##########
File path: fineract-provider/src/main/resources/META-INF/spring/appContext.xml
##########
@@ -24,17 +24,17 @@
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xmlns:context="http://www.springframework.org/schema/context";
xmlns:jpa="http://www.springframework.org/schema/data/jpa";
xmlns:sec="http://www.springframework.org/schema/security";
xmlns:tx="http://www.springframework.org/schema/tx";
xmlns:cache="http://www.springframework.org/schema/cache";
- xsi:schemaLocation="http://www.springframework.org/schema/beans
http://www.springframework.org/schema/beans/spring-beans-3.0.xsd
+ xsi:schemaLocation="http://www.springframework.org/schema/beans
http://www.springframework.org/schema/beans/spring-beans.xsd
http://www.springframework.org/schema/data/jpa
http://www.springframework.org/schema/data/jpa/spring-jpa.xsd
- http://www.springframework.org/schema/security
http://www.springframework.org/schema/security/spring-security-3.2.xsd
- http://www.springframework.org/schema/tx
http://www.springframework.org/schema/tx/spring-tx-3.0.xsd
- http://www.springframework.org/schema/context
http://www.springframework.org/schema/context/spring-context-3.0.xsd
+ http://www.springframework.org/schema/security
http://www.springframework.org/schema/security/spring-security.xsd
+ http://www.springframework.org/schema/tx
http://www.springframework.org/schema/tx/spring-tx.xsd
+ http://www.springframework.org/schema/context
http://www.springframework.org/schema/context/spring-context.xsd
http://www.springframework.org/schema/cache
http://www.springframework.org/schema/cache/spring-cache.xsd";>
<sec:global-method-security
pre-post-annotations="enabled" />
- <tx:annotation-driven />
+<!-- <tx:annotation-driven />-->
Review comment:
@ivan333m are you replacing this XML with the `@EnableTransactionManagement`
annotation in `AbstractApplicationConfiguration`, is that the same thing?
Great! Then just just remove this commented out XML, it's less confusing for
future readers than seeing this relict from the past.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
