vorburger commented on a change in pull request #642: FINERACT-724 Upgrade 
Spring Boot, Spring and Spring Security to their latest stable version
URL: https://github.com/apache/fineract/pull/642#discussion_r334991209
 
 

 ##########
 File path: 
fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/filter/TenantAwareBasicAuthenticationFilter.java
 ##########
 @@ -150,7 +147,8 @@ public void doFilter(final ServletRequest req, final 
ServletResponse res, final
                 }
             }
 
-            super.doFilter(req, res, chain);
+//            filterChain.doFilter(request, response);
+            super.doFilterInternal(request, response, filterChain);
 
 Review comment:
   as this is security sensitive, I would love someone to have a closer look at 
older vs current Spring to confirm that this `doFilterInternal` is the 
equivalent of `doFilter` ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to