vorburger commented on a change in pull request #642: FINERACT-724 Upgrade
Spring Boot, Spring and Spring Security to their latest stable version
URL: https://github.com/apache/fineract/pull/642#discussion_r334972078
##########
File path: fineract-provider/dev-dependencies.gradle
##########
@@ -27,22 +27,19 @@ dependencies {
providedRuntime("org.springframework.boot:spring-boot-starter-tomcat:${springBootVersion}")
- providedCompile(
-// [group: 'javax.servlet', name: 'servlet-api', version: '2.5'],
- )
-
compile(
[group: 'ch.vorburger.mariaDB4j', name: 'mariaDB4j', version:
'2.1.3'],
[group: 'org.springframework.boot', name:
'spring-boot-starter-web', version: springBootVersion],
[group: 'org.springframework.boot', name:
'spring-boot-starter-data-jpa', version: springBootVersion],
[group: 'org.springframework.boot', name:
'spring-boot-starter-security', version: springBootVersion],
+ [group: 'org.springframework.boot', name:
'spring-boot-starter-actuator', version: springBootVersion],
//[group: 'org.eclipse.persistence', name:
'javax.persistence', version: '2.0.0'],
[group: 'org.springframework', name: 'spring-context-support',
version: springVersion],
[group: 'org.springframework.security.oauth',
name: 'spring-security-oauth2', version: springOauthVersion],
- [group: 'org.apache.openjpa',
name:'openjpa-all', version:'2.4.1'],
- [group: 'org.apache.openjpa', name:'openjpa-maven-plugin',
version:'2.4.1'],
+ [group: 'org.apache.openjpa', name:'openjpa-all',
version:openJPAVersion],
Review comment:
I remember (going through some pain to) remove `openjpa-all` in
https://github.com/apache/fineract/pull/607/files, and am surprised to see it
still appear here. I know this just changes the version, but would you like to
check out if this could just be removed all together?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
