vorburger commented on a change in pull request #642: FINERACT-724 Upgrade
Spring Boot, Spring and Spring Security to their latest stable version
URL: https://github.com/apache/fineract/pull/642#discussion_r334987003
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataService.java
##########
@@ -32,16 +32,16 @@
DatatableData retrieveDatatable(String datatable);
- @PreAuthorize(value = "hasAnyRole('ALL_FUNCTIONS', 'REGISTER_DATATABLE')")
+ @PreAuthorize(value = "hasAnyAuthority('ALL_FUNCTIONS',
'REGISTER_DATATABLE')")
Review comment:
@ivan333m why this change? I don't know much about Spring Security myself,
but looking at
https://docs.spring.io/spring-security/site/docs/current/reference/htmlsingle/
it seems that Role and Authority are not the same, and both are still valid in
current versions? -- NB: This change also appears in other files below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
