vorburger commented on a change in pull request #722: Fineract-796 - Use Hikari
instead of Tomcat Connection Pool
URL: https://github.com/apache/fineract/pull/722#discussion_r390249062
##########
File path:
fineract-provider/src/main/resources/META-INF/spring/hikariDataSource.xml
##########
@@ -29,6 +29,15 @@
http://www.springframework.org/schema/jee
http://www.springframework.org/schema/jee/spring-jee-3.0.xsd";>
<!-- name here must match TestDataSourceConfiguration -->
- <jee:jndi-lookup jndi-name="java:comp/env/jdbc/fineract_tenants"
- id="tenantDataSourceJndi" />
+
+ <bean id="hikariTenantDataSource"
class="com.zaxxer.hikari.HikariDataSource">
+ <property name="driverClassName" value="${fineract_tenants_driver}" />
+ <property name="jdbcUrl" value="${fineract_tenants_url}" />
+ <property name="username" value="${fineract_tenants_uid}" />
+ <property name="password" value="${fineract_tenants_pwd}" />
+ <property name="minimumIdle" value="3" />
+ <property name="maximumPoolSize" value="10" />
+ <property name="idleTimeout" value="60000" />
+ <property name="ConnectionTestQuery" value="SELECT 1" />
+ </bean>
Review comment:
Let's also have this here:
```suggestion
<!--
https://github.com/brettwooldridge/HikariCP/wiki/MySQL-Configuration -->
<property name="dataSource.cachePrepStmts" value="true" />
... TODO etc.
</bean>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
