vorburger commented on a change in pull request #722: Fineract-796 - Use Hikari
instead of Tomcat Connection Pool
URL: https://github.com/apache/fineract/pull/722#discussion_r390227341
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/boot/db/DataSourceConfiguration.java
##########
@@ -38,19 +39,19 @@
@Autowired JDBCDriverConfig config ;
@Bean
- public DataSourceProperties dataSourceProperties() {
- return new DataSourceProperties(config.getDriverClassName(),
config.getProtocol(), config.getSubProtocol(), config.getPort());
+ public DataSourceProperties DataSourceProperties() {
Review comment:
why make this method name upper case? It works, by convention, class names
are upper case, and method names are lower case, and it's is a little bit
confusing to readers especially when there's an identically named class and
method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
