vorburger commented on a change in pull request #722: Fineract-796 - Use Hikari
instead of Tomcat Connection Pool
URL: https://github.com/apache/fineract/pull/722#discussion_r390234656
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/service/TomcatJdbcDataSourcePerTenantService.java
##########
@@ -85,26 +85,30 @@ private DataSource createNewDataSourceFor(final
FineractPlatformTenantConnection
//
http://www.tomcatexpert.com/blog/2010/04/01/configuring-jdbc-pool-high-concurrency
// see also org.apache.fineract.DataSourceProperties.setDefaults()
- String jdbcUrl =
this.driverConfig.constructProtocol(tenantConnectionObj.getSchemaServer(),
tenantConnectionObj.getSchemaServerPort(), tenantConnectionObj.getSchemaName())
;
- //final String jdbcUrl = tenantConnectionObj.databaseURL();
- final PoolConfiguration poolConfiguration = new PoolProperties();
-
poolConfiguration.setDriverClassName(this.driverConfig.getDriverClassName());
- poolConfiguration.setName(tenantConnectionObj.getSchemaName() +
"_pool");
- poolConfiguration.setUrl(jdbcUrl);
- poolConfiguration.setUsername(tenantConnectionObj.getSchemaUsername());
- poolConfiguration.setPassword(tenantConnectionObj.getSchemaPassword());
-
- poolConfiguration.setInitialSize(tenantConnectionObj.getInitialSize());
-
-
poolConfiguration.setTestOnBorrow(tenantConnectionObj.isTestOnBorrow());
- poolConfiguration.setValidationQuery("SELECT 1");
Review comment:
shouldn't we keep this `setValidationQuery` ? Especially because above in
`DataSourceProperties.java` you did keep it..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
