thesmallstar commented on a change in pull request #1099:
URL: https://github.com/apache/fineract/pull/1099#discussion_r443741923
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/domain/TrialBalance.java
##########
@@ -100,8 +100,9 @@ public boolean equals(Object obj) {
}
TrialBalance other = (TrialBalance) obj;
return Objects.equals(other.officeId, officeId) &&
Objects.equals(other.glAccountId, glAccountId)
- && Objects.equals(other.amount, amount) &&
Objects.equals(other.entryDate, entryDate)
- && Objects.equals(other.transactionDate, transactionDate) &&
Objects.equals(other.closingBalance, closingBalance);
+ && Objects.equals(other.amount, amount) &&
other.entryDate.compareTo(entryDate) == 0 ? Boolean.TRUE
+ : Boolean.FALSE &&
other.transactionDate.compareTo(transactionDate) == 0 ? Boolean.TRUE
Review comment:
Just curious about this:
How is `other.entryDate.compareTo(entryDate) == 0 ? Boolean.TRUE:
Boolean.FALSE`
dIfferent from just `other.entryDate.compareTo(entryDate) == 0 ` (In terms
of end result) of the boolean?
Is it because .equals returns Boolean.TRUE and not primitive data-type
boolean?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
