percyashu commented on a change in pull request #1099:
URL: https://github.com/apache/fineract/pull/1099#discussion_r443937448
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/domain/TrialBalance.java
##########
@@ -100,8 +100,9 @@ public boolean equals(Object obj) {
}
TrialBalance other = (TrialBalance) obj;
return Objects.equals(other.officeId, officeId) &&
Objects.equals(other.glAccountId, glAccountId)
- && Objects.equals(other.amount, amount) &&
Objects.equals(other.entryDate, entryDate)
- && Objects.equals(other.transactionDate, transactionDate) &&
Objects.equals(other.closingBalance, closingBalance);
+ && Objects.equals(other.amount, amount) &&
other.entryDate.compareTo(entryDate) == 0 ? Boolean.TRUE
+ : Boolean.FALSE &&
other.transactionDate.compareTo(transactionDate) == 0 ? Boolean.TRUE
Review comment:
compareTo returns an int. If values to be compared are equal, the value
returned is zero.
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/shareaccounts/domain/ShareAccount.java
##########
@@ -224,7 +224,7 @@ public boolean setSubmittedDate(final Date submittedDate) {
public boolean setApprovedDate(final Date approvedDate) {
boolean toReturn = false;
- if (!this.approvedDate.equals(approvedDate)) {
+ if (this.approvedDate.compareTo(approvedDate) == 0 ? Boolean.FALSE :
Boolean.TRUE) {
this.approvedDate = approvedDate;
Review comment:
Yeah, but I think this way is clearer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
