vorburger commented on a change in pull request #1099:
URL: https://github.com/apache/fineract/pull/1099#discussion_r444034118
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/domain/TrialBalance.java
##########
@@ -100,8 +100,9 @@ public boolean equals(Object obj) {
}
TrialBalance other = (TrialBalance) obj;
return Objects.equals(other.officeId, officeId) &&
Objects.equals(other.glAccountId, glAccountId)
- && Objects.equals(other.amount, amount) &&
Objects.equals(other.entryDate, entryDate)
- && Objects.equals(other.transactionDate, transactionDate) &&
Objects.equals(other.closingBalance, closingBalance);
+ && Objects.equals(other.amount, amount) &&
other.entryDate.compareTo(entryDate) == 0 ? Boolean.TRUE
Review comment:
@percyashu I don't understand this... given that `entryDate` and
`transactionDate` are (both) `java.util.Date`, why is `Objects.equals()` not
OK? That does not match what https://errorprone.info/bugpattern/UndefinedEquals
seems to be about... what am I missing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
