thesmallstar commented on a change in pull request #1099:
URL: https://github.com/apache/fineract/pull/1099#discussion_r443744286
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/shareaccounts/domain/ShareAccount.java
##########
@@ -224,7 +224,7 @@ public boolean setSubmittedDate(final Date submittedDate) {
public boolean setApprovedDate(final Date approvedDate) {
boolean toReturn = false;
- if (!this.approvedDate.equals(approvedDate)) {
+ if (this.approvedDate.compareTo(approvedDate) == 0 ? Boolean.FALSE :
Boolean.TRUE) {
this.approvedDate = approvedDate;
Review comment:
very very minor suggestion, can we not keep it just !=0 (this makes it
little confusing IMO).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
