vidakovic opened a new pull request #1986: URL: https://github.com/apache/fineract/pull/1986
## Description - proper Docker image build with reasonable startup parameters (the ones that were in place until now were not really great) - using the latest JDK 17 LTS release everywhere (Docker image and workflows) - Travis builds were failing, some regressions fell through the cracks (the biggest: GSON serializer was missing an adapter; without it was crashing with security exceptions as reflection is not generally allowed anymore); see: "org.apache.fineract.infrastructure.core.serialization.GoogleGsonSerializerHelper" - moved the WAR build into a separate module; it's really unnecessarily hard to make everything work in one build script without making it overly complex; main reason for move: Jib (the Docker build module) detects if a project is of type WAR and starts to do all kind of automatic WAR related configuration; the WAR stuff is not our main deliverable; maybe we can drop it in the future; anyway... still there, just different directory - I've made some small adjustments in the docker-compose.yml file; this thing is not used anymore for building the Docker images (with this change Dockerfile, entrypoint.sh and .dockerignore also disappeared) - the integration tests run now with Docker Compose instead of Cargo; no more brittle Mysql configuration and startup; this will run no matter the OS or the environment; now there is only one mechanism that handles everything (via a Docker Compose Gradle plugin) - with the move to JDK 17 the Travis builds were not working anymore; the main reason was missing JVM arguments in the gradle.properties to make the Gradle Spotless plugin properly work ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests - [x] Create/update unit or integration tests for verifying the changes made. - [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions. - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes - [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.) FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
